Browse Source

【代码评审】IoT:ThingModel 维护

YunaiV 7 tháng trước cách đây
mục cha
commit
c9904f0994

+ 3 - 1
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/dal/dataobject/receivable/CrmReceivableDO.java

@@ -66,7 +66,9 @@ public class CrmReceivableDO extends BaseDO {
      */
     private LocalDateTime returnTime;
     /**
-     * 回款方式,关联枚举{@link CrmReceivableReturnTypeEnum}
+     * 回款方式
+     *
+     * 枚举 {@link CrmReceivableReturnTypeEnum}
      */
     private Integer returnType;
     /**

+ 1 - 1
yudao-module-iot/yudao-module-iot-biz/src/main/java/cn/iocoder/yudao/module/iot/controller/admin/thingmodel/model/ThingModelParam.java

@@ -25,7 +25,7 @@ public class ThingModelParam {
     /**
      * 用于区分输入或输出参数
      *
-     * 关联枚举 {@link IotThingModelParamDirectionEnum}
+     * 枚举 {@link IotThingModelParamDirectionEnum}
      */
     private String direction;
     /**

+ 3 - 5
yudao-module-iot/yudao-module-iot-biz/src/main/java/cn/iocoder/yudao/module/iot/controller/admin/thingmodel/model/dataType/ThingModelStructDataSpecs.java

@@ -27,14 +27,12 @@ public class ThingModelStructDataSpecs extends ThingModelDataSpecs {
     private String name;
     /**
      * 云端可以对该属性进行的操作类型
-     * 关联枚举 {@link IotThingModelAccessModeEnum}
+     *
+     * 枚举 {@link IotThingModelAccessModeEnum}
      */
     private String accessMode;
     /**
-     * 是否是标准品类的必选服务。
-     *
-     * - true:是
-     * - false:否
+     * 是否是标准品类的必选服务
      */
     private Boolean required;
     /**

+ 1 - 0
yudao-module-iot/yudao-module-iot-biz/src/main/java/cn/iocoder/yudao/module/iot/dal/mysql/thingmodel/IotThingModelMapper.java

@@ -23,6 +23,7 @@ public interface IotThingModelMapper extends BaseMapperX<IotThingModelDO> {
                 .likeIfPresent(IotThingModelDO::getName, reqVO.getName())
                 .eqIfPresent(IotThingModelDO::getType, reqVO.getType())
                 .eqIfPresent(IotThingModelDO::getProductId, reqVO.getProductId())
+                // TODO @芋艿:看看要不要加枚举
                 .notIn(IotThingModelDO::getIdentifier, "get", "set", "post")
                 .orderByDesc(IotThingModelDO::getId));
     }